feat(ServerInfoDto): add optional libraryCount (v0.10.1)#13
Merged
Conversation
The hub's My Servers UI showed Libraries as '--' because ServerInfoDto (the contract for GET /api/v1/me/servers) had no library-count field. Add an optional ?int libraryCount (default null), round-tripped through from/toPayload, so the hub can surface the count it already caches in server_libraries. Absent/null tolerated for back-compat. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| CodeStyle | 3 minor |
🟢 Metrics 4 complexity · 0 duplication
Metric Results Complexity 4 Duplication 0
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #13 +/- ##
============================================
+ Coverage 57.11% 57.36% +0.24%
- Complexity 400 403 +3
============================================
Files 38 38
Lines 1215 1222 +7
============================================
+ Hits 694 701 +7
Misses 521 521
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an optional
?int libraryCounttoServerInfoDto(the contract for the hub'sGET /api/v1/me/servers), round-tripped throughfromPayload()/toPayload(), defaultnullfor back-compat. Unblocks the hub showing a real library count in My Servers instead of "—". 7 DTO tests pass, phpstan L9 + phpcs clean.